feat(onnxslim_pass):Add split_to_slice pass test and update qkv_split…#43
Open
co-seven wants to merge 1 commit into
Open
feat(onnxslim_pass):Add split_to_slice pass test and update qkv_split…#43co-seven wants to merge 1 commit into
co-seven wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends xslim.onnxslim_pass with two new ONNX graph rewrites: (1) a Split -> Slice rewrite when only a single split output is actually used, and (2) an additional QKV MatMul fusion pattern that recognizes a MatMul -> Add -> Reshape -> Transpose -> Split -> Squeeze layout and rewrites it into three independent Q/K/V branches. It also adds/updates unit tests to validate the new fusion and rewrite behaviors.
Changes:
- Add a new fusion pass (
split_to_slice) that rewrites eligibleSplitnodes into a singleSlice. - Add a new QKV fusion matcher for
MatMul/Add/Reshape/Transpose/Split/Squeezepatterns (contiguous Q/K/V weight layout). - Add tests covering the new QKV fusion and the
Split -> Slicerewrite/keep behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/test_onnxslim_pass.py |
Adds models + assertions to validate the new QKV fusion pattern and Split -> Slice rewrite behavior. |
src/xslim/onnxslim_pass/split_to_slice.py |
Introduces the SingleConsumerSplitToSlicePatternMatcher and rewrite logic. |
src/xslim/onnxslim_pass/qkv_split.py |
Adds a new matcher that fuses the reshape/transpose/split/squeeze QKV pattern into 3 branches. |
src/xslim/onnxslim_pass/__init__.py |
Ensures the new split_to_slice pass is imported/registered. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… pass