Added include_remotes = (request->data[1] & 0b10) flag to param_serve_pull_request()

[kivkiv12345]

I need to think this through tomorrow, to ensure that the flag remains as backwards compatible as possible.

[johandc]

Would it make more sense to have a param_pull, where it is possible to filter by node? Then setting the node to zero, would be the same as requesting params without remotes. But it is also possible to request a specific remote node in the request?

[kivkiv12345]

Something similar to the following param_queue_t pseudo code?:
CSH node 130
ADCS node 500
FSS node 501

PARAM_DEFINE_REMOTE(123, fss_param, 501, ...);
param_queue_t my_queue = {0};
queue_init(&my_queue, ...);
queue_add(&my_queue, &fss_param);
param_pull_queue(&my_queue, 500);

[johandc]

Well, that always works because you are explicitly defining which parameters to pull. What you have suggested is a method to pull_all, but with or without remotes. That would be a flag that sets node to either zero, or anything else. What i am suggesting, if you need this, is to instead of a flag, add a field, which sets the desired node.

so param_pull_all(host, node)

so param_pull_all(host, 0) would be all local params
and param_pull_all(host, 123) would be the specific remote node params.
and param_pull_all(host, 0xffff) could be the ALL remote params.