Introduce __attribute__((cleanup)) for memory management.#20
Open
kivkiv12345 wants to merge 1 commit intomasterfrom
Open
Introduce __attribute__((cleanup)) for memory management.#20kivkiv12345 wants to merge 1 commit intomasterfrom
kivkiv12345 wants to merge 1 commit intomasterfrom
Conversation
This commit makes us more dependant on GCC, but introduces a more reliable way to free optparse_t pointers. This commit also solves the following memory leaks: 2 missing calls to optparse_del() in loki.c (loki_start_cmd()) 6 missing calls to optparse_del() in slash_apm.c (apm_load_cmd(), apm_info_cmd()) 1 call to optparse_del() after return in prometheus.c (prometheus_start_cmd()) 1 missing call to optparse_del() in builtins.c (slash_builtin_watch())
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes us more dependant on GCC,
but introduces a more reliable way to free optparse_t pointers.
Currently this pull request solves the following memory leaks:
2 missing calls to optparse_del() in loki.c (loki_start_cmd())
6 missing calls to optparse_del() in slash_apm.c (apm_load_cmd(), apm_info_cmd())
1 call to optparse_del() after return in prometheus.c (prometheus_start_cmd())
1 missing call to optparse_del() in builtins.c (slash_builtin_watch())
csp_init_cmd() has been spared, as we deliberately leak "parser" there to keep some string pointers.