Open
Conversation
kivkiv12345
referenced
this pull request
in spaceinventor/libparam
Apr 26, 2024
kivkiv12345
referenced
this pull request
in spaceinventor/slash
Apr 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While debugging 3e8b7ce I ended up trying out renaming the slash struct.
I decided to rename it with a typedef, so it would be more similar to param_t.
The amount of files changed is quite excessive, But as I had the changes working locally anyway, I figured I might as make a Pull Request, such that we can decide whether to align slash with param_t.