This repository was archived by the owner on Jan 19, 2023. It is now read-only.
Conversation
…ned data; bypassing commit hook
|
✔️ Deploy Preview for sourcegraph-learn ready! 🔨 Explore the source changes: 7fbab7a 🔍 Inspect the deploy log: https://app.netlify.com/sites/sourcegraph-learn/deploys/614e4e3bed3a4c0007505b5b 😎 Browse the preview: https://deploy-preview-177--sourcegraph-learn.netlify.app |
…, and add search_url to toml
…r result repository name and file path
…on search component
…uctural search results display correctly
…end, update highlighter logic, add interactive search to cheat sheet
…results don't display a file link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What should this PR do?
Resolves DEVED-110 by adding an interactive search component to do interactive searches in
postsusing the Sourcegraph product.Also resolves DEVED-146 by adding a backend to the repo, which will be deployed as a separate service via Docker (see DEVED-151).
Also (last one) resolves DEVED-151, which containerizes the backend for local dev testing and deployment (see instructions for local dev below).
Right now, this feature will return a set number of string query matches from a locally configured Sourcegraph Docker container (configuration details below). In the short term, it is possible to iterate on this WIP using a local Docker setup. The next step will be configuring a more robust test setup on a dedicated test VM using the Compose workflow. From there, we can move on to configuring our prod setup.
Quick video demo
Screen.Recording.2022-01-03.at.1.50.56.PM.mov
Why are we making this change?
posts, and to be able to demonstrate Sourcegraph in action.What are the acceptance criteria?
SourcegraphInteractiveSearchcomponent.Search on Sourcegraphbutton is clicked.How should this PR be tested?
ngrok.ymlconfig file, add the following config to create two tunnels below yourauthtoken:NB: You can create multiple tunnels on a free tier account
./ngrok start --allsourcegraph/sourcegraphif you do not have it already, navigate to thedevdirectory, and run therun-server-image.shscript:./run-server-image.shlocalhost:7080and sign up for an admin account on your local instance.http://localhost:7080/site-admin/tokens. Note: this does not need to be asudotoken.http://localhost:7080/site-admin/configuration), add the following values, using yourngrokoutput from the terminal, which should look like this:In your Sourcegraph site config, add the following values:
script/install.shscript, to get the local dependencies in yourbackendandclientdirectories.backend/.envand fill out the following values:cdto theclientdirectory and start up your dev server:npm run dev. In the other pane,cdto thebackenddirectory, and fire it up:npm run start.regular-expression-patternsto see theSourcegraphInteractiveSearchcomponent in action, or add it to another record of your choosing using the following pattern:client/.env, update yourSEARCH_URLto be the following value:cdto theclientdirectory and start up your dev server:npm run dev. In the other pane,cdto thebackenddirectory, and fire up the Docker setup:docker-compose up -dregular-expression-patternsto see theSourcegraphInteractiveSearchcomponent in actionPull request process
Reviewers:
Reviewees: