fetch the expected number of rows, instead of stopping at the expecte…#29
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request modifies the CSV data frame fetching logic to fetch a specific number of rows rather than stopping at an estimated byte offset. This change aims to improve the accuracy of row fetching when byte offset estimates are imprecise, particularly in CSVs with variable row sizes.
Key changes:
- Replace byte-offset-based termination with row-count-based termination
- Add
stats.validcounter to track parsed non-empty rows - Update test expectations to reflect the new fetching behavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/dataframe.ts | Modified fetch logic to count rows instead of checking byte offsets; added stats.valid counter and changed loop termination condition |
| test/dataframe.test.ts | Updated test expectations for resolve event counts and adjusted comments to reflect that row size estimation "might" refresh (previously said "refreshes") |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d byte offset
fixes #28