Skip to content

perf: skip non-message preview lines#107

Merged
sorafujitani merged 1 commit into
mainfrom
perf/preview-prefilter-message-lines
Jul 3, 2026
Merged

perf: skip non-message preview lines#107
sorafujitani merged 1 commit into
mainfrom
perf/preview-prefilter-message-lines

Conversation

@sorafujitani

Copy link
Copy Markdown
Owner

Summary

  • add a cheap "type" byte-level prefilter before preview JSON unmarshalling
  • skip full decoding for lines that cannot be top-level user/assistant messages
  • add coverage for spaced JSON, false-positive nested message-looking content, and a tool-heavy benchmark

Fixes #100

Benchmark

Command:

go test -bench=BenchmarkRenderTextToolHeavyTranscript -benchmem ./internal/preview -count=10

benchstat /tmp/ccsession-100-before.txt /tmp/ccsession-100-after.txt:

RenderTextToolHeavyTranscript-12  7.740m ± 2%  1.420m ± 3%  -81.65% (p=0.000 n=10)
RenderTextToolHeavyTranscript-12  5.906Mi ± 0%  2.898Mi ± 0%  -50.93% (p=0.000 n=10)
RenderTextToolHeavyTranscript-12  9.975k ± 0%  2.771k ± 0%  -72.22% (p=0.000 n=10)

Verification

go test ./...
go vet ./...
golangci-lint run
gofmt -l $(git ls-files '*.go')
git diff --check

@sorafujitani sorafujitani merged commit 9d86e78 into main Jul 3, 2026
7 checks passed
@sorafujitani sorafujitani deleted the perf/preview-prefilter-message-lines branch July 3, 2026 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

perf: stop fully decoding non-message lines in preview loadMessages

1 participant