Added method attribute_names#305
Open
fr33z3 wants to merge 1 commit intosolnic:masterfrom
fr33z3:master
Open
Conversation
Author
|
27 days and no any comments and not merged, what's going on? |
Owner
|
Sorry, I have very little time for Virtus these days. Regarding this addition - I would accept it if it was a method defined on We want to add as little as possible to the interface of the class or module that includes a virtus extension. |
Collaborator
|
My first thought was that I find ActiveRecord's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added little but useful method attribute_names for Virtus model. There are a lot of cases when we need to get attribute names in a simple way.