Skip to content

Conversation

@xuan-cao-swi
Copy link
Contributor

Description

Removed unused gem from Rakefile.

  • remove Rake::TestTask as we don't use rake test to do unit test
  • remove fileutils as it's not required to delete rubocop_result.txt before each run
  • remove bundler/setup as we don't need to load any additional gem in this Rakefile, so no need for it
rake build                                         # Build solarwinds_apm-7.1.1.gem into the pkg directory
rake build:checksum                                # Generate SHA512 checksum of solarwinds_apm-7.1.1.gem into the checksums directory
rake clean                                         # Remove any temporary products
rake clobber                                       # Remove any generated files
rake docker_build                                  # Build the ubuntu docker container without cache
rake docker_con                                    # Continue the docker container created last time
rake docker_dev                                    # Start ubuntu docker container for testing and debugging
rake docker_down                                   # Stop all containers that were started for testing and debugging
rake docker_tests[tag,runtests,platform,env_vars]  # Run an official docker ruby image with the specified tag
rake install                                       # Build and install solarwinds_apm-7.1.1.gem into system gems
rake install:local                                 # Build and install solarwinds_apm-7.1.1.gem into system gems without network access
rake release[remote]                               # Create tag v7.1.1 and build and push solarwinds_apm-7.1.1.gem to rubygems.org
rake rubocop                                       # Run rubocop and generate result

Test (if applicable)

Tested docker-related task and rubocop.

@xuan-cao-swi xuan-cao-swi requested review from a team as code owners January 29, 2026 19:32
@xuan-cao-swi xuan-cao-swi requested a review from Copilot January 29, 2026 19:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up the Rakefile by removing unused dependencies and an obsolete test task. The changes streamline the Rakefile to focus on the tasks that are actually in use: bundler/gem_tasks for build/release, and custom tasks for Docker testing and Rubocop linting.

Changes:

  • Removed unused gem requires (rubygems, fileutils, net/http, optparse, digest, open-uri, bundler/setup)
  • Removed Rake::TestTask configuration that was not being used
  • Removed FileUtils.rm_f call in rubocop task since File.new creates/truncates the file anyway

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xuan-cao-swi xuan-cao-swi merged commit 959dba1 into main Jan 29, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants