feat: elicitation + pay-skills CI tooling

[lgalabru]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
payment-debugger	Ready	Preview, Comment	Jun 13, 2026 1:18am

[greptile-apps]

Greptile Summary

This PR adds MCP elicitation as an auth gate for payment signing (routing approval prompts through the MCP client UI when no local biometric is available) and introduces a provider pin system that lets users fetch a single provider's files from a specific GitHub PR, branch, or SHA into a local overlay that shadows the canonical catalog.

• Elicitation auth (mcp/src/auth.rs, keystore/src/lib.rs, signer.rs): new ElicitationAuth gate bridges the sync AuthGate trait to an async peer.create_elicitation round-trip via block_in_place; threaded through all signing paths via AuthOverride type alias and _with_override function variants.
• Pin overlay (core/src/skills/pin.rs, overlay.rs, github.rs): atomic pin store under ~/.config/pay/skills/overlay/ with staged writes, SHA-256 drift detection, and size caps; overlay is merged into every load_skills() return so pinned providers surface transparently in search, curl, etc.
• CLI commands (cli/src/commands/skills/): pay skills add extended with --pr/--branch/--sha pin mode; new pay skills prune-merged drops obsolete PR pins; pay skills list shows overlay section and "(pinned)" tags; headless setup and account creation fall back gracefully when no biometric is enrolled.

Confidence Score: 4/5

Safe to merge after addressing the SHA pin conflict logic in install.rs; all other changes are well-structured and defensive.

The SHA anchor conflict classifier treats two different user-supplied SHA values as a silent refresh rather than prompting for confirmation. A user who deliberately pins venice/ai at commit abc1234 and later runs the same command with def5678 will have their pin silently replaced. The rest of the PR is carefully implemented with good validation and test coverage.

rust/crates/cli/src/commands/skills/install.rs — classify_conflict handling of PinAnchor::Sha needs a second look

Important Files Changed

Filename	Overview
rust/crates/cli/src/commands/skills/install.rs	Major expansion adding pin mode (--pr/--branch/--sha). SHA conflict classification has a logic bug: two distinct --sha values are silently refreshed instead of prompting. --sha input lacks format validation before the GitHub API call.
rust/crates/mcp/src/auth.rs	New ElicitationAuth gate: bridges sync AuthGate trait to async MCP elicitation via block_in_place. Correctly handles Accept/Decline/Cancel, adds explicit check for content.approved=false on Accept.
rust/crates/core/src/skills/pin.rs	New PinStore with atomic upsert via staging/rename, FQN and path traversal validation, SHA-256 checksums, and sweep of orphaned temp dirs. Solid design with good test coverage.
rust/crates/core/src/skills/github.rs	New GitHub REST client with input validation, size caps, and GITHUB_TOKEN support. PrHead.repo is non-optional (deleted fork panics) — pre-existing finding.
rust/crates/core/src/signer.rs	Adds AuthOverride type alias and _and_override variants of all signing helpers, threading the optional elicitation gate through all keystore backends. Platform-specific cfg blocks are correct.
rust/crates/cli/src/commands/skills/list.rs	Adds pinned-provider display. Reads pin store twice independently from load_skills(), which can produce display inconsistencies during concurrent modifications.
rust/crates/keystore/src/lib.rs	Adds any_biometric_available() cross-platform helper and from_boxed_auth() constructor. Both are straightforward additions with appropriate cfg guards.
rust/crates/mcp/tests/elicitation_e2e.rs	E2E tests correctly marked #[ignore] with explanation that rmcp 0.9 duplex hangs on elicitation round-trips. Protocol-level unit tests in auth.rs still run.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[pay curl / MCP tool call] --> B{RunOutcome}
    B -->|X402| C[build_payment_with_override]
    B -->|MPP| D[build_credential_with_override]
    B -->|SIWX| E[build_siwx_auth_header_with_override]
    B -->|Subscription| F[build_credential_with_authenticate_and_override]
    C & D & E & F --> G[load_signer_for_network_with_intent_and_override]
    G --> H{auth_override?}
    H -->|Some - elicitation| I[ElicitationAuth::authenticate]
    H -->|None - platform| J[Touch ID / Windows Hello / polkit]
    I --> K[peer.create_elicitation via block_in_place]
    K --> L{Client response}
    L -->|Accept + approved=true| M[Sign transaction]
    L -->|Decline / Cancel / approved=false| N[AuthDenied error]
    J --> M

Loading

_{Reviews (3): Last reviewed commit: "test(mcp): ignore elicitation e2e tests ..." | Re-trigger Greptile}

[greptile-apps]

Broken requires_ifs constraint — --repo silently ignored in source mode

requires_ifs checks whether the raw string value of --repo equals "Some(_)" — a literal string that no user will ever type. The validation never fires, so pay skills add --repo my-fork venice/ai happily enters source mode and discards --repo, treating venice/ai as a catalog URL instead. The intended constraint ("--repo is only valid alongside --pr, --branch, or --sha") should use requires_one_of(["pr", "branch", "sha"]) (available in clap ≥ 4.3) or conflicts_with the absence pattern.