add music to pomodoro#357
Open
LiChenyang-GZ wants to merge 11 commits intomainfrom
Open
Conversation
Test Results24 tests 24 ✅ 2s ⏱️ Results for commit f078555. ♻️ This comment has been updated with latest results. |
|
nxn-nicole
requested changes
May 6, 2026
| if (key === "noSound") { | ||
| get().stopSoundscape(); | ||
| return; | ||
| } |
Collaborator
There was a problem hiding this comment.
I feel like you can move the "no sound" logic, maybe to initPlayer. If there's no sound, you don't need to init the player.
| set({ isPlaying: true }); | ||
| }, | ||
|
|
||
| toggleSoundscape: () => { |
Collaborator
There was a problem hiding this comment.
Is this function only used to change the soundscape mode? If it is, please give it a better name to show that it is different from other functions used to play pomodoro music.
Collaborator
Author
There was a problem hiding this comment.
it has been used in pomodoro focus to stop/play the music
nxn-nicole
requested changes
May 6, 2026
nxn-nicole
requested changes
May 8, 2026
nxn-nicole
requested changes
May 8, 2026
nxn-nicole
requested changes
May 8, 2026
nxn-nicole
requested changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.