Remove the old avatar JSON file by lyx2-2 · Pull Request #315 · sol-wizard/Blotz-Task-App

lyx2-2 · 2026-04-14T01:17:37Z

No description provided.

github-actions · 2026-04-14T01:19:08Z

Test Results

24 tests 24 ✅ 2s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit 196bd4a.

♻️ This comment has been updated with latest results.

github-actions · 2026-04-14T01:19:10Z

Package	Line Rate	Branch Rate	Complexity	Health
BlotzTask	3%	14%	1525	❌
BlotzTask	3%	14%	1525	❌
Summary	3% (1778 / 60624)	14% (196 / 1400)	3050	❌

nxn-nicole · 2026-04-23T00:42:35Z

+export function useAvatarListQuery() {
+  const avatarListQuery = useQuery<AvatarListDTO>({
+    queryKey: avatarKeys.all,
+    queryFn: () => fetchAvatarList(),


I think the data you fetched from Azure is consistent, so usually you don't need to fetch again. You can add
staleTime: Infinity,
gcTime: Infinity,

nxn-nicole · 2026-04-23T00:47:01Z

-          const isSelected = avatar.url === selectedAvatarUrl;
+        {isAvatarListError ? (
+          <Text className="w-full text-center text-base font-baloo text-secondary">
+            Failed to load avatars.


You should not hard code the string here add Chinese language support.

nxn-nicole · 2026-04-23T00:48:30Z

+    if (avatars.some((avatar) => avatar.url === pictureUrl)) {
+      setSelectedAvatarUrl(pictureUrl);
+    }
+  }, [avatars, userProfile?.pictureUrl]);


What's this useEffect doing here? If it's just to fetch the default value for avatar URL, I think you can just add it inside of useState instead of using another useEffect here.

nxn-nicole · 2026-04-23T00:58:15Z

  const { userProfile } = useUserProfile();
+  const { avatars, isAvatarListLoading, isAvatarListError } = useAvatarListQuery();
+
+  const [selectedAvatarUrl, setSelectedAvatarUrl] = useState<string | null>(null);


I think we already have the avatar URL set in user profile, so you don't need to add another local state of avatar URL here.If you need the URL, just read it from the user profile.

nxn-nicole · 2026-04-23T00:59:42Z

  const handleAvatarSelect = async (avatar: AvatarDTO) => {
    if (isUserUpdating) return;
+
+    const previousAvatarUrl = selectedAvatarUrl;


I also think it's not very useful to set a previous avatar URL here because you already use updateStateAvatar. Since you're using the useMutation function, if it fails on error, it will roll back itself. The user profile won't be updated, so you still can read the old cache value.

nxn-nicole · 2026-04-23T01:01:20Z

        isOnBoarded: userProfile?.isOnBoarded ?? false,
      });
    } catch {
+      setSelectedAvatarUrl(previousAvatarUrl);


import { Pressable, Text, View } from "react-native";
import { ReturnButton } from "@/shared/components/return-button";
import { useUserProfileMutation } from "@/feature/settings/hooks/useUserProfileMutation";
import { useUserProfile } from "@/shared/hooks/useUserProfile";
import { AvatarDTO } from "@/feature/settings/modals/avatar-dto";
import { useAvatarListQuery } from "@/feature/settings/hooks/useAvatarListQuery";
import LoadingScreen from "@/shared/components/loading-screen";
import { SafeAreaView } from "react-native-safe-area-context";
import { Image } from "expo-image";

export default function SettingsAvatarScreen() {
const { userProfile } = useUserProfile();
const { avatars, isAvatarListLoading, isAvatarListError } = useAvatarListQuery();
const { updateUserProfile, isUserUpdating } = useUserProfileMutation();

if (isAvatarListLoading) {
return ;
}

const handleAvatarSelect = async (avatar: AvatarDTO) => {
if (isUserUpdating) return;

try { await updateUserProfile({ displayName: userProfile?.displayName ?? "", pictureUrl: avatar.url, isOnBoarded: userProfile?.isOnBoarded ?? false, }); } catch { console.log("Failed to update avatar."); }

};

return (

Avatar

<View className="flex-row flex-wrap justify-between m-6"> {isAvatarListError ? ( <Text className="w-full text-center text-base font-baloo text-secondary"> Failed to load avatars. </Text> ) : ( avatars.map((avatar) => { const isSelected = avatar.url === userProfile?.pictureUrl; return ( <Pressable key={avatar.url} onPress={() => handleAvatarSelect(avatar)} className={`mb-6 items-center ${isUserUpdating ? "opacity-70" : ""}`} disabled={isUserUpdating} > <View className="rounded-full border-4" style={{ borderColor: isSelected ? "#8B86B3" : "transparent", }} > <Image source={{ uri: avatar.url }} style={{ width: 80, height: 80, borderRadius: 48 }} contentFit="cover" /> </View> </Pressable> ); }) )} </View> </SafeAreaView>

);
}

I generated this part from claude to see if this logic will make the code look better. It feels like everything's still working in this.

nxn-nicole · 2026-04-23T01:27:47Z

+  );
+}
+
+function isAvatarListDTO(value: unknown): value is AvatarListDTO {


I'm not sure whether we need a very complex type check here, because we maintain this JSON file ourselves, so usually it shouldn't have any type error.
If you want to do type validation, please use Zod instead of a manual validate function.
export const AvatarDTOSchema = z.object({
id: z.string(),
label: z.string(),
url: z.string(),
});
const AvatarListDTOSchema = z.object({
version: z.number(),
avatars: z.array(AvatarDTOSchema),
});

… avatar selection style

nxn-nicole · 2026-05-08T12:45:10Z

+import { AvatarDTO } from "@/feature/settings/modals/avatar-dto";
+import { LOCAL_AVATARS } from "@/feature/settings/constants/local-avatar-catalog";
+
+export function useAvatarListQuery() {


i don‘t think you need this. if you store avatr locally, there won't be loading and error state

nxn-nicole · 2026-05-08T12:46:15Z

-        : avatarDataDevelopment;
-  const avatars = avatarData.avatars;
  const { userProfile } = useUserProfile();
+  const { avatars, isAvatarListLoading, isAvatarListError } = useAvatarListQuery();


If you don't use query, this can also be removed.

nxn-nicole · 2026-05-08T12:46:30Z


  const { updateUserProfile, isUserUpdating } = useUserProfileMutation();

+  if (isAvatarListLoading) {


I don't feel like there will be an avatar loading state. You can delete this.

nxn-nicole · 2026-05-08T12:48:40Z

  const { userProfile } = useUserProfile();
+  const { avatars, isAvatarListLoading, isAvatarListError } = useAvatarListQuery();
+
+  const [selectedAvatarId, setSelectedAvatarId] = useState<string | null>(null);


Also, there is no need to hold a local state for the selected avatar ID. When a user clicks a new avatar, just upload it and always use userProfile.avatar as the single source of truth.

nxn-nicole · 2026-05-08T12:49:29Z

      <View className="flex-row flex-wrap justify-between m-6">
-        {avatars.map((avatar) => {
-          const isSelected = avatar.url === selectedAvatarUrl;
+        {isAvatarListError ? (


I don't feel like there will be an error state. I can't delete this.

nxn-nicole · 2026-05-08T12:50:59Z

-    : PNGIMAGES.blotzIcon;
+  const pictureValue = userProfile?.pictureUrl;
+  const SelectedAvatarComponent = getLocalAvatarComponent(pictureValue);
+  const avatarSource = isRemoteAvatarUrl(pictureValue) ? { uri: pictureValue } : PNGIMAGES.blotzIcon;


const SelectedAvatarComponent = getLocalAvatarComponent(pictureValue);
const avatarSource = pictureValue && !SelectedAvatarComponent
? { uri: pictureValue }
: PNGIMAGES.blotzIcon;
I feel like this works the same, and you can remove the function isRemoteAvatarUrl

nxn-nicole · 2026-05-08T12:51:59Z

+              />
+            )}
            <Pressable
              onPress={handleProfileEdit}


Also, if you didn't add any new package, you shouldn't have changes in package-lock.json.
You can copy the package-lock.json from main to cover your local package-lock.json to avoid changes.

lyx2-2 requested a review from nxn-nicole April 14, 2026 01:17

Phenomenax self-requested a review April 18, 2026 06:27

Phenomenax requested changes Apr 18, 2026

View reviewed changes

Comment thread blotztask-mobile/src/feature/settings/hooks/useAvatarListQuery.ts Outdated

nxn-nicole requested changes Apr 18, 2026

View reviewed changes

Comment thread blotztask-mobile/src/feature/settings/hooks/useAvatarListQuery.ts Outdated

Comment thread blotztask-mobile/src/shared/constants/query-key-factory.ts Outdated

Comment thread blotztask-mobile/src/feature/settings/screens/settings-avatar-screen.tsx

lyx2-2 force-pushed the azure-avatars-upload-support branch from d881d1e to 66aa6d3 Compare April 23, 2026 00:37

nxn-nicole requested changes Apr 23, 2026

View reviewed changes

lyx2-2 force-pushed the azure-avatars-upload-support branch from 66aa6d3 to ae3a883 Compare May 2, 2026 03:56

lyx2-2 added 4 commits May 8, 2026 14:05

Remove the old avatar JSON file

421b422

Update avatar picker to use azure remote avatar list

1e2a99b

Add avatar production json url, simplify avatar query key, and refine…

bf1b916

… avatar selection style

Change avatar to local assets

196bd4a

lyx2-2 force-pushed the azure-avatars-upload-support branch from ae3a883 to 196bd4a Compare May 8, 2026 04:08

nxn-nicole requested changes May 8, 2026

View reviewed changes


		const { updateUserProfile, isUserUpdating } = useUserProfileMutation();

		if (isAvatarListLoading) {

Conversation

lyx2-2 commented Apr 14, 2026

Uh oh!

github-actions Bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

github-actions Bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nxn-nicole Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Apr 14, 2026 •

edited

Loading

github-actions Bot commented Apr 14, 2026 •

edited

Loading

nxn-nicole Apr 23, 2026 •

edited

Loading