Skip to content

fix(mobile): resolve frontend bug bundle (#1209)#273

Open
jen12138 wants to merge 19 commits intomainfrom
fix/1209-frontend-bugs
Open

fix(mobile): resolve frontend bug bundle (#1209)#273
jen12138 wants to merge 19 commits intomainfrom
fix/1209-frontend-bugs

Conversation

@jen12138
Copy link
Copy Markdown
Collaborator

Done Fix Frontend Bugs (Language Update, Task Type Tab, Note Modal Behavior, Note Length Validation)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 25, 2026

Test Results

20 tests   20 ✅  1s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit e273edd.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 25, 2026

Package Line Rate Branch Rate Complexity Health
BlotzTask 3% 16% 1242
BlotzTask 3% 16% 1242
Summary 3% (1560 / 53890) 16% (180 / 1150) 2484

Comment thread blotztask-mobile/src/feature/notes/screens/notes-screen.tsx Outdated
Comment thread blotztask-mobile/src/feature/notes/components/note-input-modal.tsx Outdated
Comment thread blotztask-mobile/src/feature/notes/components/note-input-modal.tsx Outdated
Comment thread blotztask-mobile/src/feature/notes/components/note-input-modal.tsx Outdated
@jen12138
Copy link
Copy Markdown
Collaborator Author

Moved the note length validation out of notes-screen and into notes-service so it now throws through the existing React Query/toast flow. I also removed the manual error UI from note-input-modal and switched the modal to react-native-modal backdrop handling.

Comment thread blotztask-mobile/src/feature/task-add-edit/components/segment-toggle.tsx Outdated
Comment thread blotztask-mobile/src/feature/notes/services/notes-service.ts Outdated

return await apiClient.post(url, { text });
const trimmedText = text.trim();

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the text has already been trimmed before passing into this service, so you don't need to trim it here again.

Also, you don't need to add the try-catch block here because the return await will handle the try-catch error automatically.

Copy link
Copy Markdown
Collaborator Author

@jen12138 jen12138 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

I removed the extra trim and try/catch in notes-service.ts as suggested. The note text is already handled before calling the service, and mutation errors are already surfaced through the existing React Query + toast flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants