Skip to content

fix(Worklets): networking in Bundle Mode on some setups #9897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tjzel wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(Worklets): networking in Bundle Mode on some setups #9897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/react-native-worklets/RNWorklets.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ Pod::Spec.new do |s|

s.dependency 'React-jsi'
s.dependency 'React-hermes'

s.pod_target_xcconfig = {
"USE_HEADERMAP" => "YES",
"DEFINES_MODULE" => "YES",
Expand All @@ -70,6 +70,7 @@ Pod::Spec.new do |s|
'"$(PODS_ROOT)/DoubleConversion"',
'"$(PODS_ROOT)/Headers/Private/React-Core"',
'"$(PODS_ROOT)/Headers/Private/Yoga"',
'"$(PODS_CONFIGURATION_BUILD_DIR)/React-utils/React_utils.framework/Headers/react/utils/platform/ios"',
].join(' '),
"FRAMEWORK_SEARCH_PATHS" => '"${PODS_CONFIGURATION_BUILD_DIR}/React-hermes"',
"CLANG_CXX_LANGUAGE_STANDARD" => "c++20",
Expand Down
6 changes: 3 additions & 3 deletions packages/react-native-worklets/apple/worklets/apple/Networking/WorkletsNetworking.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@

#import <mutex>

#import <FBReactNativeSpec/FBReactNativeSpec.h>
#import <React-Core/React/RCTFollyConvert.h>
#import <React-jsi/jsi/JSIDynamic.h>
#import <ReactCommon/RCTTurboModule.h>
#import <react/utils/FollyConvert.h>
#import <jsi/JSIDynamic.h>
#import <React/RCTAssert.h>
#import <React/RCTConvert.h>
#import <React/RCTHTTPRequestHandler.h>
Expand Down
1 change: 0 additions & 1 deletion packages/react-native-worklets/apple/worklets/apple/WorkletsModule.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
#import <React/RCTCallInvoker.h>

#ifdef WORKLETS_FETCH_PREVIEW_ENABLED
#import <FBReactNativeSpec/FBReactNativeSpec.h>
#import <React/RCTNetworking.h>
#import <ReactCommon/RCTTurboModule.h>
#import <worklets/apple/Networking/WorkletsNetworking.h>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native-worklets/src/bundleMode/network.native.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* The NetworkingModule itself is injected via C++.
*/
export function initializeNetworking() {
// eslint-disable-next-line @typescript-eslint/no-require-imports
require('react-native/Libraries/TurboModule/TurboModuleRegistry');
const TurboModules = globalThis.TurboModules;

TurboModules.set('FileReaderModule', makeMockTurboModule('FileReaderModule'));
Expand Down
Loading