fix: deactivate active pseudo selectors on unregistration#9852
Draft
MatiPl01 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #9775.
When the pseudo styles are unregistered while a selector is active (e.g. a render removes the
':active'value, or the view's style loses its pseudo selectors mid-press), the gesture listeners are detached with the active state still applied: the held value stays in the updates registry and the pseudo lock keeps filtering render transitions for those properties, so the view is stuck at the pseudo value indefinitely.PseudoStylesRegistry::removenow runs the deactivation transition (active mask back to the defaults) and drops the lock before detaching. Also guardsgetPropertySettingsagainst properties whose settings never parsed (e.g. a discrete property withoutallowDiscrete), which the toggle path could previously hit as an uncaughtstd::out_of_range.Verified on the iOS simulator: removing
':active'from the style while the finger is down animates the view back to its base value (previously it stayed at the pseudo value forever).