fix: unfreeze settled pseudo-selector values on re-registration#9851
Draft
MatiPl01 wants to merge 1 commit into
Draft
fix: unfreeze settled pseudo-selector values on re-registration#9851MatiPl01 wants to merge 1 commit into
MatiPl01 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #9775.
A pseudo-selector toggle records its settled value in the updates registry, and the commit hook re-applies that value over every React commit. For a property that has a transition config this self-heals (the next render transition overwrites the entry), but a property styled only through a pseudo selector (no transition config) never runs another transition - so after a single press/release the view freezes at its tap-time value and ignores all later renders.
This refreshes the settled (unlocked, not currently animating) pseudo-styled values held in the updates registry with the newly registered defaults on every pseudo-styles registration, which runs on each render that changes them.
Verified on the iOS simulator: a
backgroundColor: { default: renderColor, ':active': ... }box with no transition config resumes following render-driven color changes after a tap (previously it stayed frozen indefinitely), with no change to hold/quick-tap behavior.