chore: remove onStartShouldSetResponder workaround from :active examples#9795
Closed
MatiPl01 wants to merge 1 commit into
Closed
chore: remove onStartShouldSetResponder workaround from :active examples#9795MatiPl01 wants to merge 1 commit into
MatiPl01 wants to merge 1 commit into
Conversation
MatiPl01
force-pushed
the
@matipl01/android-active-window-observer
branch
from
4a86cd4 to
0de1a1f
Compare
MatiPl01
changed the base branch from
main
to
@matipl01/svg-pseudo-selectors-android
MatiPl01
force-pushed
the
@matipl01/android-active-window-observer
branch
from
0de1a1f to
3b2d421
Compare
MatiPl01
force-pushed
the
@matipl01/android-active-window-observer
branch
2 times, most recently
from
f6e992a to
a4671ec
Compare
Now that press pseudo-selectors are driven from the window observer, the onStartShouldSetResponder workaround is unnecessary for the regular-view :active / :active-deepest examples. The four SVG examples keep it pending an on-device check of SVG :active without the responder.
MatiPl01
changed the title
MatiPl01
force-pushed
the
@matipl01/android-active-window-observer
branch
from
a4671ec to
a220fd0
Compare
Member
Author
|
Superseded by #9918 (identical commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
onStartShouldSetResponder={() => true}workaround from the regular-view:active/:active-deepestexamples, now that Android press pseudo-selectors are driven from the window observer (stacked on #9879).The four SVG examples keep the prop until SVG
:activewithout a responder is checked on device.