Add Imperative Gesture Handler Testing API#4309
Draft
coado wants to merge 2 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces an imperative testing helper (createGestureController) to simplify gesture lifecycle testing in RNGH Jest utilities, enabling step-by-step state transitions and assertions without manually crafting low-level state/oldState events.
Changes:
- Added
createGestureController,GestureController, andGestureControllerEventto drive gesture lifecycles imperatively in tests. - Exported the new controller API from
src/jestUtils/index.ts. - Added Jest tests covering lifecycle sequencing, validation, testID resolution, and disabled-gesture behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/react-native-gesture-handler/src/jestUtils/jestUtils.ts | Adds the gesture controller implementation and public API surface. |
| packages/react-native-gesture-handler/src/jestUtils/index.ts | Re-exports the controller types and factory function. |
| packages/react-native-gesture-handler/src/tests/gestureController.test.tsx | Adds tests validating the new imperative controller behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The goal is to make gesture lifecycle tests easier to write when we want to assert application state after each gesture step, without requiring users to manually construct RNGH state events with
state,oldState, orhandlerTag.Instead of this lower-level style:
tests can now use imperative controller:
Test plan
Added tests using new API.