Skip to content

fix: reset cached style state in Fabric prepareForRecycle to stop stale-markdown flicker #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mvanhorn wants to merge 2 commits into
base: main
Choose a base branch
from
+32 −2
Open

fix: reset cached style state in Fabric prepareForRecycle to stop stale-markdown flicker #482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bafd09d
fix: reset cached style state in Fabric prepareForRecycle to stop sta…
mvanhorn Jul 2, 2026
8fd2895
fix: reset md4c flags to prop baseline on recycle, not defaultFlags
mvanhorn Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion packages/react-native-enriched-markdown/ios/EnrichedMarkdown.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -931,7 +931,8 @@ - (void)didMoveToWindow

- (void)prepareForRecycle
{
_props = std::make_shared<const EnrichedMarkdownProps>();
const auto resetProps = std::make_shared<const EnrichedMarkdownProps>();
_props = resetProps;
[_renderCoordinator invalidate];

for (RCTUIView *segment in _segmentViews) {
Expand All @@ -949,8 +950,21 @@ - (void)prepareForRecycle

_cachedMarkdown = nil;
_renderedMarkdown = nil;
_config = nil;
_md4cFlags = [ENRMMd4cFlags defaultFlags];
_md4cFlags.underline = resetProps->md4cFlags.underline;
_md4cFlags.superscript = resetProps->md4cFlags.superscript;
_md4cFlags.subscript = resetProps->md4cFlags.subscript;
_md4cFlags.latexMath = resetProps->md4cFlags.latexMath;
_md4cFlags.highlight = resetProps->md4cFlags.highlight;
_maxFontSizeMultiplier = 0;
_allowTrailingMargin = NO;
_streamingAnimation = NO;
_tableStreamingMode = ENRMTableStreamingModeProgressive;
_renderedStyleFingerprint = 0;
_pendingStyleFingerprint = 0;
_contextMenuItemTexts = nil;
_contextMenuItemIcons = nil;
_dirtyFlags = ENRMDirtyNone;

[super prepareForRecycle];
Expand Down
18 changes: 17 additions & 1 deletion packages/react-native-enriched-markdown/ios/EnrichedMarkdownText.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,8 @@ - (void)didMoveToWindow

- (void)prepareForRecycle
{
_props = std::make_shared<const EnrichedMarkdownTextProps>();
const auto resetProps = std::make_shared<const EnrichedMarkdownTextProps>();
_props = resetProps;
[_renderCoordinator invalidate];

[_fadeAnimator cancel];
Expand All @@ -639,10 +640,25 @@ - (void)prepareForRecycle
_forceHeightUpdateOnNextRender = NO;
_cachedMarkdown = nil;
_renderedMarkdown = nil;
_config = nil;
_md4cFlags = [ENRMMd4cFlags defaultFlags];
_md4cFlags.underline = resetProps->md4cFlags.underline;
_md4cFlags.superscript = resetProps->md4cFlags.superscript;
_md4cFlags.subscript = resetProps->md4cFlags.subscript;
_md4cFlags.latexMath = resetProps->md4cFlags.latexMath;
_md4cFlags.highlight = resetProps->md4cFlags.highlight;
_maxFontSizeMultiplier = 0;
_lastElementMarginBottom = 0;
_allowTrailingMargin = NO;
_renderedStyleFingerprint = 0;
_pendingStyleFingerprint = 0;
_contextMenuItemTexts = nil;
_contextMenuItemIcons = nil;
_accessibilityElements = nil;
_accessibilityInfo = nil;
_accessibilityNeedsRebuild = NO;
[_spoilerManager removeAllOverlays];
_spoilerManager = nil;
if (_textView != nil) {
ENRMSetAttributedText(_textView, [[NSAttributedString alloc] initWithString:@""]);
_textView.hidden = YES;
Expand Down
Loading