fix(ios): convert img attributes to integer values#688
Merged
hejsztynx merged 1 commit intoJul 8, 2026
Conversation
szydlovsky
approved these changes
Jul 8, 2026
hejsztynx
merged commit da0ea3a
into
@ksienkiewicz/fix-android-normalizer-number-parsing
2 tasks
hejsztynx
added a commit
that referenced
this pull request
Jul 9, 2026
# Summary HTML parser on Android explicitly tired to parse `<img>` dimension attributes `height` and `width` as `Integer`, with no exception caught, which caused the whole parser to bail. Web and iOS outputs HTML with float dimensions, so using that HTML in Android would break the input. Also I got rid of the core cause of this issue - made the iOS parser function the same as the Android one and they both now converts both dimension attributes to integer values. #688 ## Testing Example HTML that would break if used in `Set input's value` ```html <html> <p>Asd<img src="asd" width="30.000000" height="30.000000"/></p> </html> ``` ## Screenshots / Videos iOS on the left, Android on the right Before: https://github.com/user-attachments/assets/acf3b65a-62c0-4e95-b97d-945115341b1a After: https://github.com/user-attachments/assets/306bba36-42b0-45ac-af18-706839c90ea0 ## Compatibility | OS | Implemented | | ------- | :---------: | | iOS | ❌ | | Android | ✅ | | Web | ❌ | ## Checklist - [ ] E2E tests are passing - [ ] Required E2E tests have been added (if applicable)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Now the
imgattributes are converted to integer. It's truthful to official HTML5 specifications, wherewidthandheightshould be integer values and the floating point in HTML could be destructive, which could produce a similar issue as in#685
Screenshots
When adding an image via modal with
heightandwidthset to30Before:
After:
Compatibility
Checklist