docs: update Worklets import forwarding setup#22
Open
eliotgevers wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the React Native Worklets setup instructions to use
importForwardingforremendwhen usingreact-native-worklets0.10 or newer.With the old
workletizableModulesoption on newer Worklets versions,remendcan be captured into the generated worklet closure as a remote function, which can cause this runtime error whenStreamdownTextmounts:The updated config forwards the
remendimport into the generated worklet so markdown preprocessing can still run on the worklet runtime. The docs also keep a short note for older Worklets versions that still useworkletizableModules.Closes #21.
Changes
workletizableModules: ['remend']withimportForwarding: { moduleNames: ['remend'] }in the setup examplesreact-native-workletsversionsTest plan
react-native-worklets0.10.xremenddirectly instead of capturing it in__closureStreamdownTextrenders without the remote function error