Open
Conversation
Closed
Jonathan-Rasch
approved these changes
Mar 5, 2020
Collaborator
Jonathan-Rasch
left a comment
Jonathan-Rasch
left a comment
There was a problem hiding this comment.
Seems good. is the Pipfile.lock needed or should that go in the gitignore ?
Member
Author
|
I think the lockfile is meant to be there, it ensures that the same version
of each dependency is installed each time, otherwise sometimes there’s a
newer one that breaks things..
…On Thu, 5 Mar 2020 at 18:17, Jonathan-Rasch ***@***.***> wrote:
***@***.**** approved this pull request.
Seems good. is the Pipfile.lock needed or should that go in the gitignore ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1?email_source=notifications&email_token=AAVSMKQZBED5GUZK4E5JYGDRF7UCNA5CNFSM4K5SIZ5KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCYFL5LQ#pullrequestreview-369802926>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVSMKVZURTKBV3FEQKZKFLRF7UCNANCNFSM4K5SIZ5A>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also added Pipenv to manage project dependencies