This repository was archived by the owner on Mar 10, 2020. It is now read-only.
allow sub-manager tasks to use own app rather than parent's#104
Open
emosbaugh wants to merge 1 commit intosmurfix:masterfrom
Open
allow sub-manager tasks to use own app rather than parent's#104emosbaugh wants to merge 1 commit intosmurfix:masterfrom
emosbaugh wants to merge 1 commit intosmurfix:masterfrom
Conversation
Author
|
the example in the readme does not work for me. when i call python manage.py runserver it starts the parent app (MyApp) rather than the sub-manager app (MyAdminApp). def gen_admin(app, **kwargs):
from myweb.admin import MyAdminApp
## easiest but possibly incomplete way to copy your settings
return MyAdminApp(config=app.config, **kwargs)
sub_manager = Manager(gen_admin)
manager = Manager(MyApp)
manager.add_command("admin", sub_manager) |
|
I see this issue too. The build is only failing because the build for the original branch was failing for Python 3.3 at that time. Rebasing would fix that. |
arnuschky
added a commit
to arnuschky/flask-script
that referenced
this pull request
Jun 23, 2015
|
Any word on getting in? As it stands right now the submanager functionality is broken because the |
dext0r
added a commit
to dext0r/flask-script
that referenced
this pull request
Oct 17, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it was hard for me to understand the logic in this method. i have tried to amend it to make the sub-manager task use its app rather than the parent's. all unit tests pass. perhaps another should be written to assert the correct app is used for default tasks.