Merged
Conversation
This respects rust-version field in Cargo.toml, so it removes the need to manage MSRV in both the CI file and Cargo.toml.
``` pkg install -y git Updating FreeBSD repository catalogue... pkg: http://pkgmir.geo.freebsd.org/FreeBSD:12:amd64/quarterly/meta.txz: Not Found repository FreeBSD has no meta file, using default settings pkg: http://pkgmir.geo.freebsd.org/FreeBSD:12:amd64/quarterly/packagesite.pkg: Not Found pkg: http://pkgmir.geo.freebsd.org/FreeBSD:12:amd64/quarterly/packagesite.txz: Not Found Unable to update repository FreeBSD Error updating repositories! ```
This lint does not take into account destructors.
```
error: field `0` is never read
--> src\iocp\mod.rs:1155:13
|
1155 | Waiting(WaitHandle),
| ------- ^^^^^^^^^^
| |
| field in this variant
|
= note: `-D dead-code` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(dead_code)]`
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
|
1155 | Waiting(()),
| ~~
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lint does not take into account destructors. dead_code suggestion for unused fields does not account for changes to auto trait implementations rust-lang/rust#119645
https://github.com/smol-rs/polling/actions/runs/7435513674/job/20230928568
This target is currently broken due to std::net::bind using -1 for openbsd which in turn sets it to somaxconn. rust-lang/rust#119026.
https://github.com/smol-rs/polling/actions/runs/7435513674/job/20230928224
This respects rust-version field in Cargo.toml, so it removes the need to manage MSRV in both the CI file and Cargo.toml.