fix: prevent op inject overwrite prompt with multiple secrets files#29
Merged
smartwatermelon merged 1 commit intomainfrom Mar 28, 2026
Merged
Conversation
…hare basename When both global (~/.config/claude-code/secrets.op) and project-level (.claude/secrets.op) secrets files exist, inject_secrets() created temp files using basename alone, causing filename collisions in the shared temp directory. The second op inject --out-file hit the existing file and prompted for overwrite confirmation. Prefix each temp filename with a loop index counter so stripped-, resolved-, and normalized- files are unique across iterations. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
smartwatermelon
deleted the
claude/fix-secrets-basename-collision-3f8a2c
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/.config/claude-code/secrets.op) and project-level (.claude/secrets.op) secrets files exist,inject_secrets()created temp files usingbasenamealone, causing filename collisions in the shared temp directoryop inject --out-filehit the already-existing file and prompted for overwrite confirmation every launchTest plan
claudein a repo that has its own.claude/secrets.opwhile global secrets also exist — confirm no overwrite promptclaudein a repo with only global secrets — confirm no regressiontests/test-wrapper.sh— 77/78 pass (1 pre-existing failure unrelated)🤖 Generated with Claude Code