Skip to content

Use builtins #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sfarthin wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use builtins #319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff1415f
Upgrade babel
Mar 4, 2020
c969ef8
old present was left-over
Mar 4, 2020
379236a
Stop depending on babel-polyfill and set useBuiltIns: usage
Mar 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .babelrc
View file
Open in desktop

This file was deleted.

3 changes: 3 additions & 0 deletions babel.config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"presets": [["@babel/preset-env", { "corejs": "2", "useBuiltIns": "usage" }]]
}
8 changes: 3 additions & 5 deletions karma.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ module.exports = function(config) {

// list of files / patterns to load in the browser
files: [
// Load the babel polyfill
'node_modules/babel-polyfill/dist/polyfill.js',
// We need to use singl entry file to avoid circular import error between
// `aspect.js` and `conversion.js`
'src/index.js',
Expand Down Expand Up @@ -80,9 +78,9 @@ module.exports = function(config) {
// test results reporter to use
// possible values: 'dots', 'progress'
// available reporters: https://npmjs.org/browse/keyword/karma-reporter
reporters: reporters,
reporters,
// Write testing results to json file.
jsonReporter: jsonReporter,
jsonReporter,

// web server port
port: 9876,
Expand All @@ -109,7 +107,7 @@ module.exports = function(config) {
browserNoActivityTimeout: 600 * 1000,
browserDisconnectTimeout: 60 * 1000,
browserDisconnectTolerance: 3,
browsers: browsers,
browsers,
customLaunchers: !local && customLaunchers,

// Continuous Integration mode
Expand Down
31 changes: 13 additions & 18 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@
"scripts": {
"build": "webpack",
"danger": "duti",
"test": "babel-node ./node_modules/mocha/bin/_mocha --require ./test/init.js",
"test": "mocha --require @babel/register --require ./test/init.js",
"test:watch": "chokidar 'src/*.js' 'test/*.js' -c 'npm t'",
"browser": "TEST_ENV=browser karma start karma.conf.js",
"browser:local": "karma start karma.conf.js",
"coverage": "nyc --require babel-core/register --require babel-polyfill --require ./test/init.js mocha test",
"cicoveralls": "nyc report --reporter=text-lcov --require babel-core/register --require babel-polyfill --require ./test/init.js mocha test | coveralls",
"cicoverage": "nyc --reporter=lcov --require babel-core/register --require babel-polyfill --require ./test/init.js mocha test --reporter json > test-results.json",
"coverage": "nyc --require @babel/register --require ./test/init.js mocha test",
"cicoveralls": "nyc report --reporter=text-lcov --require @babel/register --require ./test/init.js mocha test | coveralls",
"cicoverage": "nyc --reporter=lcov --require @babel/register --require ./test/init.js mocha test --reporter json > test-results.json",
"lint": "eslint dangerfile.js src/*.js test/*.js",
"lint:ci": "npm run lint -- -o lint-results.json -f json",
"lint-fix": "eslint dangerfile.js src/*.js test/*.js --fix",
Expand All @@ -27,27 +27,22 @@
},
"license": "MIT",
"dependencies": {
"babel-polyfill": "^6.23.0",
"core-js": "^2.6.11",
"lodash": "^4.17.4"
},
"babel": {
"presets": [
"env"
]
},
"prettier": {
"singleQuote": true,
"semi": false,
"trailingComma": "es5"
},
"devDependencies": {
"babel": "^6.5.2",
"babel-cli": "^6.22.2",
"babel-core": "^6.22.1",
"babel-eslint": "^8.0.0",
"babel-loader": "^7.0.0",
"babel-plugin-transform-object-rest-spread": "^6.26.0",
"babel-preset-env": "^1.6.1",
"@babel/cli": "^7.8.4",
"@babel/core": "^7.8.6",
"@babel/node": "^7.8.4",
"@babel/preset-env": "^7.8.6",
"@babel/register": "^7.8.6",
"babel-eslint": "^10.1.0",
"babel-loader": "^8.0.6",
"bluebird": "^3.5.0",
"chai": "^4.1.0",
"chai-as-promised": "^7.1.1",
Expand All @@ -70,7 +65,7 @@
"karma-webpack": "^3.0.0",
"mocha": "^6.2.2",
"mocha-lcov-reporter": "^1.2.0",
"nyc": "^12.0.1",
"nyc": "^15.0.0",
"prettier": "^1.7.4",
"read-pkg": "^5.2.0",
"sinon": "^7.5.0",
Expand Down