Replace all hyphens in adapter name with underscore#730
Merged
Conversation
Contributor
NPM Publishing labels 🏷️🔵 This PR has the |
mxiao-cll
approved these changes
Mar 31, 2026
Contributor
|
🚀 Successfully created version bump PR: #707 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using
yarn newin external-adapters-js to create a new adapter, if the adapter name has a hyphen in it, this hyphen gets replaced with an underscore, as well as the letter turned to upper case, to determine the name of the adapter object.See for example "generic-api" became "GENERIC_API".
But if the name has multiple hyphens, only the first one gets replaced by an underscore and we need to fix this manually, which sometimes is forgotten. For example "bitgo-reserves-test" became "BITGO_RESERVES-TEST".
Changes
Fix the template code to call
replaceAllinstead ofreplace.Testing
In
external-adapters-js:packages/scripts/package.jsonto the local framework repo with the fix.yarn newand follow the instructions.aa-bb-cc-dd.packages/sources/aa-bb-cc-dd/src/index.ts