Skip to content

Template checks#52

Merged
russell-stern merged 8 commits into
mainfrom
template_checks
May 28, 2026
Merged

Template checks#52
russell-stern merged 8 commits into
mainfrom
template_checks

Conversation

@russell-stern
Copy link
Copy Markdown
Collaborator

Summary:

Added github actions to check that templates compile against the sdk they are targeting. Updated all templates to pass the check with the latest sdk version

Changes:

  • Added 2 github actions. A non-privileged check action to compile the targeted sdk and compile the template against and a privileged action to leave a comment on the PR with the results of the check
  • Updated all TS templates to target ^1.6.0 instead of ^1.5.0
  • Updated any templates that were failing the new compilation check

@russell-stern russell-stern marked this pull request as ready for review April 30, 2026 16:31
@russell-stern russell-stern requested review from a team as code owners April 30, 2026 16:31
Copy link
Copy Markdown
Collaborator

@ernest-nowacki ernest-nowacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have similar feedback like in SDK version around github workflows and scripts in file, other than that looks fantastic.

smartcontractkit/cre-sdk-typescript#249

ernest-nowacki
ernest-nowacki previously approved these changes May 4, 2026
@russell-stern russell-stern merged commit 678c2ef into main May 28, 2026
6 checks passed
@russell-stern russell-stern deleted the template_checks branch May 28, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants