Skip to content

[DX-3667] Codeowners Cleanup#21837

Merged
kalverra merged 2 commits intodevelopfrom
codeownersTweak
Apr 2, 2026
Merged

[DX-3667] Codeowners Cleanup#21837
kalverra merged 2 commits intodevelopfrom
codeownersTweak

Conversation

@kalverra
Copy link
Copy Markdown
Collaborator

@kalverra kalverra commented Apr 2, 2026

  • Uses trailing slashes for less-ambiguous assignments. This prevents odd behavior with some systems or new files.
  • Cleans up some dead or typoed lines

Here's the full effective changes when it comes to ownership.

Changed ownership:
  .github/workflows/devenv-compat.yml                @smartcontractkit/devex-cicd -> @smartcontractkit/devex-tooling
  .github/workflows/devenv-core-compat.yml           @smartcontractkit/devex-cicd -> @smartcontractkit/devex-tooling
  /core/services/ocr2/plugins/s4/                    @smartcontractkit/foundations -> @smartcontractkit/dev-services

@kalverra kalverra changed the title Codeowners Cleanup [DX-3667] Codeowners Cleanup Apr 2, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

✅ No conflicts with other open PRs targeting develop

@kalverra kalverra marked this pull request as ready for review April 2, 2026 20:16
@kalverra kalverra requested review from a team as code owners April 2, 2026 20:16
Copilot AI review requested due to automatic review settings April 2, 2026 20:16
@kalverra kalverra requested review from a team as code owners April 2, 2026 20:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Risk Rating: MEDIUM — changes affect CODEOWNERS precedence and therefore review/approval routing for multiple paths.

This PR updates repository ownership rules to be less ambiguous (mostly by adding trailing slashes / fixing paths) and removes stale CODEOWNERS entries.

Changes:

  • Normalize many CODEOWNERS patterns to directory-scoped rules (trailing /) and correct several paths.
  • Remove CODEOWNERS entries that point to non-existent files/paths (e.g., old workflow names, old internal/config/..., and a non-existent deployment/ccip/changeset/ton path).
  • Adjust .github/copilot-instructions.md by removing the “Reviewer Recommendations” section and renumbering subsequent sections.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/copilot-instructions.md Removes the “Reviewer Recommendations” guidance section and renumbers “Code Style” to section 3.
.github/CODEOWNERS Cleans up and normalizes ownership patterns (adds trailing slashes, fixes paths, removes stale entries), and introduces a wildcard rule for devenv* workflows.

Comment on lines 101 to +103
/.github/workflows/build-publish.yml @smartcontractkit/devex-cicd
/.github/workflows/performance-tests.yml @smartcontractkit/devex-tooling
/.github/workflows/automation-ondemand-tests.yml @smartcontractkit/dev-services
/.github/workflows/automation-benchmark-tests.yml @smartcontractkit/dev-services
/.github/workflows/automation-load-tests.yml @smartcontractkit/dev-services
/.github/workflows/automation-nightly-tests.yml @smartcontractkit/dev-services
/.github/workflows/devenv-ocr2.yml @smartcontractkit/devex-tooling
/tools/plugout @smartcontractkit/devex-cicd
/.github/workflows/devenv* @smartcontractkit/devex-tooling @smartcontractkit/devex-cicd @smartcontractkit/core
/tools/plugout/ @smartcontractkit/devex-cicd
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description says devenv-compat.yml and devenv-core-compat.yml ownership changes from @smartcontractkit/devex-cicd to @smartcontractkit/devex-tooling, but the new rule /.github/workflows/devenv* still includes @smartcontractkit/devex-cicd (and @smartcontractkit/core). If the intent is to move primary/sole ownership to devex-tooling, remove devex-cicd/core from this pattern or add file-specific rules that match the stated ownership changes.

Copilot uses AI. Check for mistakes.
@kalverra kalverra added this pull request to the merge queue Apr 2, 2026
Merged via the queue into develop with commit 61370ca Apr 2, 2026
82 checks passed
@kalverra kalverra deleted the codeownersTweak branch April 2, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants