Conversation
|
✅ No conflicts with other open PRs targeting |
There was a problem hiding this comment.
Pull request overview
Risk Rating: MEDIUM — changes affect CODEOWNERS precedence and therefore review/approval routing for multiple paths.
This PR updates repository ownership rules to be less ambiguous (mostly by adding trailing slashes / fixing paths) and removes stale CODEOWNERS entries.
Changes:
- Normalize many CODEOWNERS patterns to directory-scoped rules (trailing
/) and correct several paths. - Remove CODEOWNERS entries that point to non-existent files/paths (e.g., old workflow names, old
internal/config/..., and a non-existentdeployment/ccip/changeset/tonpath). - Adjust
.github/copilot-instructions.mdby removing the “Reviewer Recommendations” section and renumbering subsequent sections.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/copilot-instructions.md |
Removes the “Reviewer Recommendations” guidance section and renumbers “Code Style” to section 3. |
.github/CODEOWNERS |
Cleans up and normalizes ownership patterns (adds trailing slashes, fixes paths, removes stale entries), and introduces a wildcard rule for devenv* workflows. |
| /.github/workflows/build-publish.yml @smartcontractkit/devex-cicd | ||
| /.github/workflows/performance-tests.yml @smartcontractkit/devex-tooling | ||
| /.github/workflows/automation-ondemand-tests.yml @smartcontractkit/dev-services | ||
| /.github/workflows/automation-benchmark-tests.yml @smartcontractkit/dev-services | ||
| /.github/workflows/automation-load-tests.yml @smartcontractkit/dev-services | ||
| /.github/workflows/automation-nightly-tests.yml @smartcontractkit/dev-services | ||
| /.github/workflows/devenv-ocr2.yml @smartcontractkit/devex-tooling | ||
| /tools/plugout @smartcontractkit/devex-cicd | ||
| /.github/workflows/devenv* @smartcontractkit/devex-tooling @smartcontractkit/devex-cicd @smartcontractkit/core | ||
| /tools/plugout/ @smartcontractkit/devex-cicd |
There was a problem hiding this comment.
The PR description says devenv-compat.yml and devenv-core-compat.yml ownership changes from @smartcontractkit/devex-cicd to @smartcontractkit/devex-tooling, but the new rule /.github/workflows/devenv* still includes @smartcontractkit/devex-cicd (and @smartcontractkit/core). If the intent is to move primary/sole ownership to devex-tooling, remove devex-cicd/core from this pattern or add file-specific rules that match the stated ownership changes.
Here's the full effective changes when it comes to ownership.