Draft
Conversation
Contributor
|
I see you updated files related to
|
Contributor
|
✅ No conflicts with other open PRs targeting |
Contributor
CORA - Pending Reviewers
Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown For more details, see the full review summary. |
Contributor
Author
|
The ci core tests are timing out with 15 minutes 🤔 |
jmank88
force-pushed
the
golang-1.26.1
branch
2 times, most recently
from
88e621a to
1eda476
Compare
jmank88
commented
Apr 2, 2026
| Headers: map[string]string{}, | ||
| Body: nil, | ||
| Timeout: 1 * time.Second, | ||
| Timeout: 10 * time.Second, |
Contributor
Author
There was a problem hiding this comment.
This was required to prevent the two hex cases from timing out. They take ~6 seconds for some reason?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notice this changes how mockery files are generated. That is because of goimports changes in go 1.26. It may cause some disruption, but I think it is just something we have to get past (and it is a better end state).