Open
Conversation
Contributor
|
✅ No conflicts with other open PRs targeting |
Contributor
There was a problem hiding this comment.
Pull request overview
Risk Rating: HIGH — Changes affect CI gating/trigger logic for ci-core, with potential for missed test execution or unexpected resource usage.
This PR migrates ci-core change detection from dorny/paths-filter to the shared advanced-triggers action, aiming to reduce unnecessary workflow runs via more granular file-set based triggers.
Changes:
- Replace
dorny/paths-filter-based outputs withadvanced-triggersoutputs (core-tests,core-fuzz-tests,core-race-tests,core-integration-tests,deployment-tests). - Define reusable
file-setsand per-job trigger rules using inclusion/exclusion sets and explicit paths. - Update downstream
should-runselectors to use the new trigger outputs.
erikburt
force-pushed
the
feat/ci-core-advanced-triggers
branch
from
20e9540 to
fcb5b10
Compare
kalverra
reviewed
Mar 27, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new step
advanced-triggerswhich in the future will be used to gate jobs more effectively. This is on purpose for a "roll-out" phase where we will continue to rely on the old-logic, but can cross-reference what the new logic would've done, and if it was correct.Changes
advanced-triggersNotes
Related to #21659, #21686.
Testing
Tested these triggers during development:
DX-3534