Skip to content

Add CRE settings for gateway relay rate limits#1950

Open
nadahalli wants to merge 2 commits intomainfrom
tejaswi/relay-gateway-settings
Open

Add CRE settings for gateway relay rate limits#1950
nadahalli wants to merge 2 commits intomainfrom
tejaswi/relay-gateway-settings

Conversation

@nadahalli
Copy link
Copy Markdown
Contributor

Summary

  • add dedicated CRE settings for confidential relay gateway global and per-node rate limits
  • document the new settings in the cresettings README and defaults goldens
  • keep the defaults aligned with the current relay handler behavior

Testing

  • go test ./pkg/settings/cresettings

@nadahalli nadahalli requested a review from a team as a code owner April 1, 2026 11:29
Copilot AI review requested due to automatic review settings April 1, 2026 11:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds two new CRE settings to control confidential relay gateway rate limits (global and per-node), with defaults and documentation kept in sync with the existing CRE settings/golden workflow.

Changes:

  • Introduce GatewayConfidentialRelayGlobalRate and GatewayConfidentialRelayPerNodeRate in the CRE settings schema and defaults.
  • Extend the unmarshal test coverage to validate parsing of the new rate settings.
  • Document the new settings in the CRE settings README mermaid diagram and update defaults.{json,toml} goldens.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/settings/cresettings/settings.go Adds the two new rate-limit settings to Schema and Default.
pkg/settings/cresettings/settings_test.go Verifies JSON unmarshal parses the new settings into config.Rate values.
pkg/settings/cresettings/README.md Documents the new settings in the gateway handler limits diagram.
pkg/settings/cresettings/defaults.toml Updates TOML golden defaults to include new keys/values.
pkg/settings/cresettings/defaults.json Updates JSON golden defaults to include new keys/values.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

✅ API Diff Results - github.com/smartcontractkit/chainlink-common

✅ Compatible Changes (2)

pkg/settings/cresettings.Schema (2)
  • GatewayConfidentialRelayGlobalRate — ➕ Added

  • GatewayConfidentialRelayPerNodeRate — ➕ Added


📄 View full apidiff report

@nadahalli nadahalli requested a review from MStreet3 April 1, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants