Add CRE settings for gateway relay rate limits#1950
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds two new CRE settings to control confidential relay gateway rate limits (global and per-node), with defaults and documentation kept in sync with the existing CRE settings/golden workflow.
Changes:
- Introduce
GatewayConfidentialRelayGlobalRateandGatewayConfidentialRelayPerNodeRatein the CRE settings schema and defaults. - Extend the unmarshal test coverage to validate parsing of the new rate settings.
- Document the new settings in the CRE settings README mermaid diagram and update
defaults.{json,toml}goldens.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/settings/cresettings/settings.go | Adds the two new rate-limit settings to Schema and Default. |
| pkg/settings/cresettings/settings_test.go | Verifies JSON unmarshal parses the new settings into config.Rate values. |
| pkg/settings/cresettings/README.md | Documents the new settings in the gateway handler limits diagram. |
| pkg/settings/cresettings/defaults.toml | Updates TOML golden defaults to include new keys/values. |
| pkg/settings/cresettings/defaults.json | Updates JSON golden defaults to include new keys/values. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a1ee74b to
7b5db1a
Compare
✅ API Diff Results -
|
jmank88
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing