Skip to content

Ccip-9778 Adding EVM contract verification metadata#1937

Merged
AnieeG merged 14 commits intomainfrom
ccip-9778-metadata
Apr 7, 2026
Merged

Ccip-9778 Adding EVM contract verification metadata#1937
AnieeG merged 14 commits intomainfrom
ccip-9778-metadata

Conversation

@AnieeG
Copy link
Copy Markdown
Contributor

@AnieeG AnieeG commented Apr 6, 2026

  • Changed input type to chain family for VerifyDeployContracts post hook

Copilot AI review requested due to automatic review settings April 6, 2026 19:16
@AnieeG AnieeG requested review from a team as code owners April 6, 2026 19:16
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

👋 AnieeG, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the deployment contract-verification plumbing to operate on chain families (e.g., EVM) and seeds additional EVM contract verification metadata so deployed contracts can be verified against explorers more consistently.

Changes:

  • Update contract verification registry + multifamily post-hook to key off chain family strings rather than chain selectors.
  • Extend verified-env pre-hook to scope verification by selectors, and consolidate hook/concurrency tests into a single test file.
  • Register additional EVM contract metadata (type/version → standard JSON input, bytecode, contract name) used by the EVM verification provider.

Reviewed changes

Copilot reviewed 15 out of 18 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
deployment/utils/common.go Adds more contract type identifiers (notably pools/modules) for metadata/lookup.
deployment/testadapters/adapters.go Import ordering only.
deployment/hooks/verification.go Switches registry lookup + post-hook to chain family; adds selector-scoped pre-hook filtering and supported-family checks.
deployment/hooks/hooks_test.go Consolidates multifamily + verifier iteration parallelism tests into one file and updates for new APIs.
deployment/hooks/verification_multifamily_test.go Removed (replaced by consolidated tests).
deployment/hooks/iterate_verifiers_parallel_test.go Removed (replaced by consolidated tests).
chains/evm/deployment/v1_6_0/testadapter/test_adapter.go Adds ERC20 fee/token approvals before sending CCIP messages.
chains/evm/deployment/v1_6_0/sequences/adapter.go Extracts FeeQuoter address+version discovery via OnRamp into a helper.
chains/evm/deployment/v1_6_0/operations/ccip_home/ccip_home.go Introduces CCIPHome ContractType constant.
chains/evm/deployment/utils/verification/hooks_test.go Updates pre-hook/post-hook calls for new signatures.
chains/evm/deployment/utils/verification/hooks_provider.go Auto-registers EVM verification provider; makes raw metadata fields unexported.
chains/evm/deployment/go.mod / go.sum Adds ccip-owner-contracts dependency.
ccv/chains/evm/deployment/v1_7_0/adapters/init.go Registers verification metadata for v2.0.0 CCV/EVM contracts at init.
ccv/chains/evm/deployment/go.mod / go.sum Dependency updates (indirect additions).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread deployment/hooks/verification.go Outdated
Comment thread chains/evm/deployment/v1_6_0/testadapter/test_adapter.go Outdated
Comment thread chains/evm/deployment/v1_6_0/sequences/adapter.go
Comment thread deployment/hooks/verification.go Outdated
carte7000
carte7000 previously approved these changes Apr 6, 2026
tt-cll
tt-cll previously approved these changes Apr 6, 2026
@AnieeG AnieeG enabled auto-merge April 6, 2026 20:26
@tt-cll tt-cll self-requested a review April 6, 2026 20:38
carte7000
carte7000 previously approved these changes Apr 6, 2026
@AnieeG AnieeG added this pull request to the merge queue Apr 6, 2026
@tt-cll tt-cll removed this pull request from the merge queue due to a manual request Apr 6, 2026
@AnieeG AnieeG dismissed stale reviews from carte7000 and tt-cll via 1b665d8 April 6, 2026 20:56
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

Metric ccip-9778-metadata main
Coverage 70.1% 69.8%

@AnieeG AnieeG enabled auto-merge April 6, 2026 21:47
@AnieeG AnieeG added this pull request to the merge queue Apr 6, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 6, 2026
@AnieeG AnieeG added this pull request to the merge queue Apr 6, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 6, 2026
@AnieeG AnieeG added this pull request to the merge queue Apr 6, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 6, 2026
@AnieeG AnieeG added this pull request to the merge queue Apr 6, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 6, 2026
@AnieeG AnieeG added this pull request to the merge queue Apr 6, 2026
Merged via the queue into main with commit c60412b Apr 7, 2026
57 checks passed
@AnieeG AnieeG deleted the ccip-9778-metadata branch April 7, 2026 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants