Separate _WINDOWS64 and _XBOX_ONE#248
Merged
void2012 merged 1 commit intosmartcmd:mainfrom Mar 3, 2026
Merged
Conversation
The latter returning to the original 512 value.
|
Hey, dude, I recommend following the rule: Note: IF YOUR PR CHANGES THE GAME BEHAVIOR VISIBLY, REMEMBER TO ATTACH A GAMEPLAY FOOTAGE (or at least a screenshot) OF YOU ACTUALLY PLAYING THE GAME WITH YOUR CHANGES. Untested PRs are NOT welcome. Please don't forget to describe what did you do in each commit in your PR. Before this PR gets closed. |
EnderActually
pushed a commit
to EnderActually/MinecraftConsoles
that referenced
this pull request
Mar 3, 2026
The latter returning to the original 512 value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Note: IF YOUR PR CHANGES THE GAME BEHAVIOR VISIBLY, REMEMBER TO ATTACH A GAMEPLAY FOOTAGE (or at least a screenshot) OF YOU ACTUALLY PLAYING THE GAME WITH YOUR CHANGES. Untested PRs are NOT welcome. Please don't forget to describe what did you do in each commit in your PR.
Description
Briefly describe the changes this PR introduces.
Changes
Previous Behavior
Describe how the code behaved before this change.
Root Cause
#246 (comment)
New Behavior
Describe how the code behaves after this change.
Fix Implementation
Simply gave each one a separate definition and set the _XBOX_ONE one to its original value.
Related Issues