[Draft] [Requires dll rewrite] Make nightly ci skip on non important stuff / other small changes#167
[Draft] [Requires dll rewrite] Make nightly ci skip on non important stuff / other small changes#167Twig6943 wants to merge 1 commit intosmartcmd:mainfrom
Conversation
|
Why removing the .dll-s though? |
void2012
added
infra
Twig6943
changed the title
UlisesMilles
left a comment
UlisesMilles
left a comment
There was a problem hiding this comment.
removing those files has catastrophic results, the other changes are ok to commit
There was a problem hiding this comment.
iggy_w64.dll is required in order for iggy to read all the necesary flash files that contain the textures
There was a problem hiding this comment.
mss64.dll is required for the executable to launch
There was a problem hiding this comment.
this is the library that handles sounds, it is required for sound to work
There was a problem hiding this comment.
while game does launch and, gameplay seems to not be afected, dolby atmos support is dropped and game crashes upon trying to load the sound profile
There was a problem hiding this comment.
while game does launch and, gameplay seems to not be afected, directX3d sound support is dropped and game crashes upon trying to load the sound profile
|
@UlisesMilles I realized that afterwards. Once those are replaced this can be merged |
|
Closing for now as there's a while for the dlls to be rewritten |
3 participants
Small changes
Builds fine: https://github.com/Twig6943/MinecraftConsoles/actions/runs/22592419558/job/65453594198