dump data for gemm umd path#20
Open
Kotomi-Du wants to merge 1 commit into
Open
Conversation
smarcink
reviewed
Apr 2, 2024
Owner
smarcink
left a comment
smarcink
left a comment
There was a problem hiding this comment.
Some comments. Also please add dumping data for reference OCL path so it can be used for comparison
| ConformanceResult validate_conformance(ID3D12CommandQueue* command_queue, | ||
| ID3D12CommandAllocator* command_allocator, ID3D12GraphicsCommandList* command_list, bool print_mismatche) override | ||
| { | ||
| auto dump_buffer_to_file = [&](const auto& buffer, const auto& file_name) |
Owner
There was a problem hiding this comment.
Similar lambda is in convolution umd dispatcher - could it be moved to be separate function?
| readback_buffer->Unmap(0, nullptr); | ||
|
|
||
| // Assuming data_out now contains the float data | ||
| float* float_ptr = reinterpret_cast<float*>(data_out.data()); |
|
|
||
| // Assuming data_out now contains the float data | ||
| float* float_ptr = reinterpret_cast<float*>(data_out.data()); | ||
| size_t num_floats = data_out.size() / sizeof(float); |
| readback_buffer->Unmap(0, nullptr); | ||
|
|
||
| // Assuming data_out now contains the float data | ||
| float* float_ptr = reinterpret_cast<float*>(data_out.data()); |
Owner
There was a problem hiding this comment.
Float assumption is fine, but probably not always valid as scratchpad can have arbitrary data type <- you may want to add such extended comment so it will be clear for code reader in future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.