fixing take_raw dropping the externref before resolving it.#244
Open
muenchow wants to merge 1 commit intoslowli:mainfrom
Open
fixing take_raw dropping the externref before resolving it.#244muenchow wants to merge 1 commit intoslowli:mainfrom
muenchow wants to merge 1 commit intoslowli:mainfrom
Conversation
|
I can confirm that the bug exist and this patch fixes it. If a function returns an owned externref to JS, its always null. Any change to get merged into main @slowli ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Currently, a
#[externref]function that returns aResource<..>will always returnnull.The issue lies in
Resource::take_raw: it drops the resource (and frees the slot) beforeget_externrefis called.This means that by the time
get_externreftries to retrieve theExternRef, the underlying resource has already been dropped.Fix
The fix is to delay dropping the
Resource<..>until the end of the function.This ensures that
get_externrefcan lookup theExternRefbefore the slot is emptied.