Add __format__ support for date and datetime classes#174
Open
meshya wants to merge 3 commits into
Open
Conversation
5j9
reviewed
Dec 9, 2025
| return self.strftime('%Y-%m-%d %H:%M:%S') + f'{mil}{tz}' | ||
|
|
||
| def __format__(self, _format): | ||
| if _format == 's': |
Contributor
There was a problem hiding this comment.
As far as I know, the built-in datetime does not support s or f as format specifiers for timestamps. Since jdatetime aims to maintain maximum compatibility with the built-in datetime, I’m not sure that adding these specifiers is a good idea
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__format__method todateclass with default format%Y-%m-%d__format__method todatetimeclass with special format specifiers:'s'- Unix timestamp as integer'f'- Unix timestamp as floatstrftime()