feat: list available ".env" variable names for non-hosted apps#437
Open
zimeg wants to merge 1 commit intozimeg-feat-load-hook-dotenvfrom
Open
feat: list available ".env" variable names for non-hosted apps#437zimeg wants to merge 1 commit intozimeg-feat-load-hook-dotenvfrom
zimeg wants to merge 1 commit intozimeg-feat-load-hook-dotenvfrom
Conversation
zimeg
added
enhancement
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## zimeg-feat-load-hook-dotenv #437 +/- ##
===============================================================
+ Coverage 70.27% 70.28% +0.01%
===============================================================
Files 220 220
Lines 18534 18540 +6
===============================================================
+ Hits 13024 13031 +7
+ Misses 4336 4335 -1
Partials 1174 1174 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zimeg
commented
Mar 25, 2026
Member
Author
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
* Thoughts for the fantastic reviewers! *
Comment on lines
+38
to
+44
| "List environment variables available to the app at runtime.", | ||
| "", | ||
| "This command is supported for apps deployed to Slack managed infrastructure but", | ||
| "other apps can attempt to run the command with the --force flag.", | ||
| "Commands that run in the context of a project source environment variables from", | ||
| "the \".env\" file. This includes the \"run\" command.", | ||
| "", | ||
| "The \"deploy\" command gathers environment variables from the \".env\" file as well", | ||
| "unless the app is using ROSI features.", |
| return err | ||
| } | ||
| } else { | ||
| dotEnv, err := hooks.LoadDotEnv(clients.Fs) |
Member
Author
There was a problem hiding this comment.
🪝 note: We reuse the logic that hooks has for gathering environment variables for confidence in matching!
🐟 ramble: We don't require app selection before this at this point, but we might consider keeping it to avoid breaking change if it becomes required later. FWIW it's required for hosted apps so this is familiar experience I think!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Summary
This PR lists available
.envvariable names for non-hosted apps to match what's available to hooks and theruncommand.Preview
Reviewers
Your check is so appreciated. The following commands might recommend testing:
When done please do delete these apps! This is the environment command kindplace 🌲 ✨
Requirements