[Core] Suppress SAWarning for CasbinRule#6796
Merged
DanielZhangQD merged 3 commits intomasterfrom Aug 21, 2025
Merged
Conversation
aylei
reviewed
Aug 21, 2025
Comment on lines
+26
to
+27
| # Suppress SQLAlchemy warnings about duplicate class names in | ||
| # sqlalchemy_adapter |
Collaborator
There was a problem hiding this comment.
Why does it raise this warning at the first place?
Collaborator
Author
There was a problem hiding this comment.
sqlalchemy_adapter v1.4.0 introduced a change in apache/casbin-python-sqlalchemy-adapter#4, where if no data_class is set when initialize Adapter, it will create a new data class with the same name CasbinRule, which is same with the default one.
I updated the PR to use the default CasbinRule when initialize Adapter.
massaindustries
pushed a commit
to Seeweb/skypilot
that referenced
this pull request
Aug 26, 2025
* fix sawarning for casbin_rule * use default casbin rule class * update ut
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suppress SAWarning for CasbinRule. Fix #6772
Tested (run the relevant ones):
bash format.shskycommands do not report warning/usr/local/lib/python3.10/site-packages/sqlalchemy_adapter/adapter.py:33: SAWarning: This declarative base already contains a class with the same class name and module name as sqlalchemy_adapter.adapter.CasbinRule, and will be replaced in the string-lookup table.after the fix./smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)