ci(toolchain-sync): gate nightly bump on clippy, drop redundant cargo check#324
Merged
Conversation
… check Harden the `just toolchain-sync` recipe so it only pins a nightly that the PR merge gate will actually accept. - Add a clippy gate using the SAME strict flags as the merge gate (--workspace --all-targets --locked --no-deps -- -D warnings), probed for both --all-features and --no-default-features. A nightly that merely compiles can still fail the gate via a new/renamed lint or a now-stale #[expect(...)] (e.g. the nightly-2026-05-31 unused_async -> unused_async_trait_impl split and duration_suboptimal_units no longer firing). On failure, step back one day instead of pinning it. - Drop the separate `cargo check` phase: clippy is a superset of check (full compile front-end + lint passes) and can't reuse the check driver's artifacts, so running both compiled the workspace an extra time for no extra signal. The clippy gate is now the single compile+lint step (3 workspace compiles -> 2, matching the gate). - Renumber phases (1 install, 2 clippy gate, 3 component verification) and update the header algorithm + rationale docs accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens the
just toolchain-syncrecipe so it only pins a nightly the PR merge gate will actually accept.--workspace --all-targets --locked --no-deps -- -D warnings), probed for both--all-featuresand--no-default-features. A nightly that merely compiles can still fail the gate via a new/renamed lint or a now-stale#[expect(...)](e.g. nightly-2026-05-31unused_async→unused_async_trait_implsplit;duration_suboptimal_unitsno longer firing). On failure, step back one day instead of pinning it.cargo checkphase: clippy is a superset of check (full compile front-end + lint passes) and cannot reuse the check driver's artifacts, so running both compiled the workspace an extra time for no extra signal. The clippy gate is now the single compile+lint step (3 workspace compiles → 2, matching the gate).Single-file change (
just/shared.just). Locallint-pre-pushpassed fully.🤖 Generated with Claude Code