Update deps #328
Merged
Update deps #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
0pcom
commented
Nov 29, 2025
0pcom
commented
added 16 commits
August 23, 2025 18:05
Minor formatting cleanup to trigger CI re-run.
Root Cause: ----------- The smux library was upgraded to v1.5.44 (likely via `go get -u ./...`), which introduced breaking changes in stream multiplexing behavior. In commit 3aef70af, smux changed the shaper channel from unbuffered to buffered, altering synchronization/timing in the multiplexing layer. Impact: ------- TestHTTPTransport_RoundTrip was failing on Darwin CI with errors like: - "stream closed" on concurrent /hash endpoint requests - "session shutdown" after first failure - "connection reset by peer" in DMSG stream layer The test spawns 3 HTTP clients making 10 concurrent requests each (30 total). Client3's /hash requests consistently failed while /index.html and /echo requests from other clients succeeded. This pattern indicated a concurrency issue in the underlying stream multiplexing. Solution: --------- Downgrade github.com/xtaci/smux from v1.5.44 to v1.5.40, restoring the previous unbuffered channel behavior that DMSG was designed for. The same fix was applied to skywire repository in commit a52c15b00. Testing: -------- After downgrade, TestHTTPTransport_RoundTrip passes reliably with all 30 concurrent requests succeeding (verified with race detector enabled).
…1.5.40" This reverts commit 598d35b.
Improvements to handle concurrent requests more reliably: 1. Added defer-based stream cleanup in RoundTrip - Ensures DMSG stream is closed if errors occur after DialStream - Prevents stream leaks when req.Write() or ReadResponse() fail 2. Added 10-second timeout to http.Client in tests - Prevents test from hanging if streams fail - Provides clearer failure mode for debugging These changes should help with the Darwin CI test failures where concurrent HTTP requests were experiencing 'stream closed' and 'session shutdown' errors under the new smux v1.5.44 buffered channel behavior.
Added nolint:errcheck directive with comment explaining this is best-effort cleanup on an error path where we're already returning an error to the caller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.