Randomize dmsg servers in dmsg.Prod #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Note that this does not solve a retry loop when dmsg-disc can't be connected to by the first dmsg server which is connected to. It will only potentially mitigate this from happening every time because the same server won't be used first every time. We still need to improve the logic to handle retry loops better, when connecting to dmsg-disc via dmsghttp. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having some issues with dmsgweb not actually connecting to dmsg as it should with the new the default of connecting via the dmsghttp-config.
so i've implemented the same logic which was already implemented in skywire for randomizing the order of dmsg servers, so that clients will not by default all attempt to connect via the same dmsg server.