Stop on Ctrl+C
#305
Merged
Stop on Ctrl+C
#305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 20, 2025 15:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the failure to shut down with
ctrl+cof all dmsg subcommands by the inclusion of a kill loop in the command wrapper init function.it will kill the application / subcommand after 3 X
ctrl+cwhich permits any graceful shutdown logic to attempt to work,, rather than just killing the application instantlyThis may not be the best thing to put in an init function, as it should only be done once and has the potential to affect lots of other things. However, it's possible to work around this entirely since it's only included in the command wrapper. But again it will affect anything that imports the wrapper - i.e. skywire.
We need better process control. Perhaps this is a first step in that direction.