feat: split visitObjectLikeType into visitObjectType and visitIntersectionType#110
Merged
feat: split visitObjectLikeType into visitObjectType and visitIntersectionType#110
visitObjectLikeType into visitObjectType and visitIntersectionType#110Conversation
…tersectionType` Recently `withOptional` was changed to no longer return an `IntersectionType`. It returns a normal `InterfaceType` instead. The `Visitor<R>` interface used to combine intersections and "normal objects" into a single `visitObjectLikeType` to prevent confusion, but that confusion is probably gone now. Therefore, the `visitObjectLikeType` is now split into `visitObjectType` and `visitIntersectionType`. BREAKING CHANGE: `Visitor<R>` interface now requires two new methods `visitObjectType` and `visitIntersectionType` while the existing `visitObjectLikeType` is removed.
njirem
approved these changes
Feb 13, 2025
pavadeli
added a commit
that referenced
this pull request
Feb 18, 2025
…tersectionType` (#110) * feat: split `visitObjectLikeType` into `visitObjectType` and `visitIntersectionType` Recently `withOptional` was changed to no longer return an `IntersectionType`. It returns a normal `InterfaceType` instead. The `Visitor<R>` interface used to combine intersections and "normal objects" into a single `visitObjectLikeType` to prevent confusion, but that confusion is probably gone now. Therefore, the `visitObjectLikeType` is now split into `visitObjectType` and `visitIntersectionType`. BREAKING CHANGE: `Visitor<R>` interface now requires two new methods `visitObjectType` and `visitIntersectionType` while the existing `visitObjectLikeType` is removed. * chore: update docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently
withOptionalwas changed to no longer return anIntersectionType. It returns a normalInterfaceTypeinstead. TheVisitor<R>interface used to combine intersections and "normal objects" into a singlevisitObjectLikeTypeto prevent confusion, but that confusion is probably gone now. Therefore, thevisitObjectLikeTypeis now split intovisitObjectTypeandvisitIntersectionType.BREAKING CHANGE:
Visitor<R>interface now requires two new methodsvisitObjectTypeandvisitIntersectionTypewhile the existingvisitObjectLikeTypeis removed.