Feature/merge validate pipeline#469
Open
Shashankss1205 wants to merge 1 commit into
Open
Conversation
5312466 to
a143beb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
See also:
feature/merge_load_data_sourcepr-469(branch:feature/merge_validate_pipeline)It is built directly on top of:
pr-468(feature/merge_load_data_source)pr-466(feature/data_management)pr-463(feature/remove-legacy-discovery-tools)What does this implement/fix? Explain your changes.
This PR merges the standalone
validate_pipelinetool directly into theinstantiate_pipelinelifecycle:validate_pipelinetool schema registration and routing logic fromserver.py.executor.instantiate_pipeline) already runs the pipeline composition validator, callinginstantiate_pipelinenow automatically checks validity first. If validation fails, it returns detailed errors and suggestions rather than registering the invalid handle.test_pipeline_composition_checkunderTestPipelineParamsValidationintests/test_param_validation.pyto confirm that trying to instantiate invalid compositions (e.g. chaining forecasters like["NaiveForecaster", "ExponentialSmoothing"]) correctly triggers composition validation and fails gracefully with detailed diagnostics.This helps maintain a lean, highly integrated, and failsafe developer API surface.
Does your contribution introduce a new dependency? If yes, which one?
No.
What should a reviewer concentrate their feedback on?
make checkreturns completely green and that all 190 tests pass.success: Falsealong with the validation diagnostics.Any other comments?
N/A
PR checklist
For all contributions
make check).docs/source/.examples/.