merge load data source async and sync together using a flag#468
Open
Shashankss1205 wants to merge 2 commits into
Open
merge load data source async and sync together using a flag#468Shashankss1205 wants to merge 2 commits into
Shashankss1205 wants to merge 2 commits into
Conversation
2826e14 to
3dc4ce4
Compare
3dc4ce4 to
703bd16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
See also:
feature/data_managementWhat does this implement/fix? Explain your changes.
This PR merges the
load_data_sourceandload_data_source_asynctools into a single, unifiedload_data_sourcetool utilizing arun_asyncboolean flag:load_data_source_tool(config, run_async=False)indata_tools.py.server.pyto route both types of operations seamlessly.load_data_source_asynctool registration and files exports.test_async_data_loading.pyto leverage the new unified tool with therun_async=Trueflag.This significantly simplifies the MCP API surface while preserving complete flexibility for loading large custom files in the background without timeout issues.
Does your contribution introduce a new dependency? If yes, which one?
No.
What should a reviewer concentrate their feedback on?
make check.run_asyncparameter to the core tool handler.Any other comments?
N/A
PR checklist
For all contributions
make check).docs/source/.examples/.