Skip to content

merge load data source async and sync together using a flag#468

Open
Shashankss1205 wants to merge 2 commits into
mainfrom
feature/merge_load_data_source
Open

merge load data source async and sync together using a flag#468
Shashankss1205 wants to merge 2 commits into
mainfrom
feature/merge_load_data_source

Conversation

@Shashankss1205

Copy link
Copy Markdown
Collaborator

Reference Issues/PRs

See also: feature/data_management

What does this implement/fix? Explain your changes.

This PR merges the load_data_source and load_data_source_async tools into a single, unified load_data_source tool utilizing a run_async boolean flag:

  • Merged the tool functions into load_data_source_tool(config, run_async=False) in data_tools.py.
  • Updated the fastmcp schema and call routing in server.py to route both types of operations seamlessly.
  • Removed the separate load_data_source_async tool registration and files exports.
  • Updated all associated unit tests in test_async_data_loading.py to leverage the new unified tool with the run_async=True flag.

This significantly simplifies the MCP API surface while preserving complete flexibility for loading large custom files in the background without timeout issues.

Does your contribution introduce a new dependency? If yes, which one?

No.

What should a reviewer concentrate their feedback on?

  • Verify that all 189 unit tests pass perfectly via make check.
  • Verify that FastMCP routing is correctly accepting and passing the run_async parameter to the core tool handler.

Any other comments?

N/A

PR checklist

For all contributions
  • I've added unit tests and made sure they pass locally (make check).
  • I've added the tool to the online documentation in docs/source/.
  • I've updated the existing example scripts or provided a new one to showcase how my tool works in examples/.

@Shashankss1205 Shashankss1205 self-assigned this Jun 1, 2026
@Shashankss1205 Shashankss1205 force-pushed the feature/merge_load_data_source branch from 2826e14 to 3dc4ce4 Compare June 4, 2026 19:49
@Shashankss1205 Shashankss1205 force-pushed the feature/merge_load_data_source branch from 3dc4ce4 to 703bd16 Compare June 4, 2026 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants