Skip to content

Conversation

@mithilP007
Copy link

Fixes #1747

Adds a conditional check to display a clear message when there is only one column in the dataframe, instead of showing the misleading "No strong associations" message.

The new message: "No associations computed because there is only one column."

Fixes skrub-data#1747

Adds a conditional check to display a clear message when there is only one column in the dataframe, instead of showing the misleading "No strong associations" message.

The new message: "No associations computed because there is only one column."
@mithilP007
Copy link
Author

The test failure on test (macos-latest, ci-py309-min-deps) is due to a CI infrastructure issue, not related to the code changes in this PR.

The error shows a network timeout while fetching dependencies:

× failed to solve the pypi requirements of 'ci-nightly-deps'
└─► operation timed out

This is a transient issue with accessing https://pypi.anaconda.org/scientific-python-nightly-wheels/simple/pyarrow/. All other 23 checks passed successfully. The code changes are working as intended.

@rcap107
Copy link
Member

rcap107 commented Nov 18, 2025

The test failure on test (macos-latest, ci-py309-min-deps) is due to a CI infrastructure issue, not related to the code changes in this PR.

The error shows a network timeout while fetching dependencies:

× failed to solve the pypi requirements of 'ci-nightly-deps'
└─► operation timed out

This is a transient issue with accessing https://pypi.anaconda.org/scientific-python-nightly-wheels/simple/pyarrow/. All other 23 checks passed successfully. The code changes are working as intended.

I restarted the jobs, everything seems to be working now

@rcap107
Copy link
Member

rcap107 commented Nov 18, 2025

Hi @mithilP007, thanks for the PR. Could you please add a small test in test_table_report.py that checks that the correct message is shown when the associations are skipped? Both when they are skipped because the number of columns is larger than max_association_columns, and when there is only one column (this specific PR).

We can merge it after the test is added.

@rcap107 rcap107 modified the milestone: Release 0.6.3 Nov 20, 2025
rcap107 and others added 2 commits November 24, 2025 21:23
Removed # noqa: F401 lint suppression comments from the else block (sklearn >= 1.5) to maintain consistency with the if block (sklearn < 1.5) where these comments were already removed. This addresses the code review feedback from coderabbital bot.
@MarieSacksick
Copy link
Contributor

Hi @mithilP007 :)!
Could you please remove the changes about # noqa: F401 in scikit-learn compat file? It looks like it's breaking the CI, plus it's not related to the goal fo the PR.

You can do pre-commit run --all-files locally to check that this part of the CI passes. (cf the contributing guide to know more about it).

@rcap107
Copy link
Member

rcap107 commented Dec 3, 2025

Thanks for the comment @MarieSacksick, you're completely right. I must have lost track of this PR.

@mithilP007 as Marie mentioned, the latest commit is not useful for the PR, so it should be reverted.

Do you need help with the test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TableReport - Improving the association tab error message when only one column is present

3 participants