-
Notifications
You must be signed in to change notification settings - Fork 192
Adding a "Discover" object for finding candidate tables that may be joined on the main table #1153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
rcap107
wants to merge
28
commits into
skrub-data:main
Choose a base branch
from
rcap107:discover
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcap107
commented
Nov 21, 2024
| .installed.cfg | ||
| *.egg | ||
| *.pkl | ||
| data/ |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to ignore the files I am using locally to test the object.
… polars selectors.
… polars selectors.
…ests for CSV parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this will be a long one!
The objective of this PR is adapting part of the pipeline from this paper: https://arxiv.org/abs/2402.06282 (repo https://github.com/rcap107/retrieve-merge-predict).
Main points:
transformis a ranking of candidate joins that includes the query column in the main table, the path to the candidate table, the key in the candidate table and the containmentSome of the problems/things that should be considered for later:
MultiAggJoinercould be used at the end to combine all the candidates into a big table.Notes on the current implementation:
_discover.pyfor now.read_parquetandread_csvdispatched functions, but I am having trouble because the only argument that they need isinput_path, and the dispatcher can't use that to decide which library to use. For the time being, I am passing X just to give that information.Discoverobject are not in the class itself, should I move them in? It's probably the better option.The current code version is barebones, but it runs. Mostly, I am having trouble with integrating the code properly.