Official docker client #42
Conversation
nterbogt
force-pushed
the
official-docker-client-build
branch
from
6d29011 to
6fb9f3d
Compare
cmd/skpr/package/command.go
Outdated
|
|
||
| // See if we're using default builder. | ||
| userConfig, _ := user.NewClient() | ||
| featureFlags, _ := userConfig.LoadFeatureFlags() |
There was a problem hiding this comment.
We've already loaded the feature flags up in the main.go
The client feature flag could get passed down into this NewCommand.
There was a problem hiding this comment.
I did look at that... but found that every single function in userConfig does a .load(). That .load() isn't cached and reads the file every time. So I figured I wouldn't add in the complexity of passing it through all the way. But I'll update it.
internal/docker/factory.go
Outdated
|
|
||
| func NewClientFromUserConfig(auth auth.Auth) (DockerClient, error) { | ||
| // See if we're using default builder. | ||
| userConfig, _ := user.NewClient() |
There was a problem hiding this comment.
Errors aren't being handled.
I also think the name of the client should be passed in vs loaded multiple times. This set of packages doesn't have to be tightly coupled to the feature flags.
There was a problem hiding this comment.
Ignoring the errors was intentional. The config is only needed if it exists, if it has a docker-client setting and if that setting is a valid option... otherwise it uses the default. So if the config fails to load, we use the defaults.
But I guess it doesn't matter cause main.go throws error if it fails to load.
nterbogt
force-pushed
the
official-docker-client-build
branch
from
6fb9f3d to
6975b8a
Compare
Refactor
skpr packageandskpr pullto use a replaceable docker client. Implement an experimental config to switch between implementations. Set the default implementation to the existing go client.Add the following to your configuration to test it.